Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Permissions screen on budgets throw errors #11532

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Conversation

alecslupu
Copy link
Contributor

🎩 What? Why?

This PR fixes the admin permission on budget's project

📌 Related Issues

Link your PR to an issue

Testing

  1. Login as admin, and navigate to admin interface
  2. Navigate to a participatory process, budget component
  3. Select a Budget, then on Projects visit the permission screen
  4. See error
  5. Apply patch
  6. See there is no error, and the data can be seen

📷 Screenshots

Please add screenshots of the changes you are proposing
Description

♥️ Thank you!

@alecslupu alecslupu added module: budgets type: fix PRs that implement a fix for a bug labels Aug 27, 2023
@alecslupu alecslupu added this to the 0.28.0 milestone Aug 27, 2023
@alecslupu alecslupu marked this pull request as ready for review August 27, 2023 12:51
@alecslupu alecslupu requested a review from a team August 28, 2023 07:48
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it locally and also the spec on develop and it fails. 👍🏽

@andreslucena
Copy link
Member

Also FYI this isn't respecting the git branch conventions.

@andreslucena andreslucena merged commit 18036d4 into develop Aug 29, 2023
93 checks passed
@andreslucena andreslucena deleted the fix/11292 branch August 29, 2023 08:54
entantoencuanto added a commit that referenced this pull request Aug 30, 2023
* develop:
  Add recognition to BrowserStack in the README (#11546)
  Remove unused view hook for `:upcoming_meeting_for_card` (#11543)
  Remove unused dependency: `wicked` (#11150)
  Clean-up initiatives signature URLs and methods (#11545)
  Refactor initiative signing wizard (#10731)
  Fix Permissions screen on budgets throw errors (#11532)
  Redesign: read more literal (#11516)
  Fix 'download your data' when there are comments on budgets (#11531)
entantoencuanto added a commit that referenced this pull request Sep 8, 2023
…gn-staging

* fix/activities-block-follow-button: (27 commits)
  Add tests to follow button in processes and assemblies landing page
  Add follow button to participatory spaces last activities content block
  Remove duplication from participatory spaces publications controllers (#11549)
  Fix the a11y tool icons with redesign (#11175)
  Remove duplication from amendments events specs (#11553)
  Remove duplication from elections' user roles forms (#11548)
  Update Node.js from v16.13.0 to v18.17.1 (#11564)
  Remove duplication from stats presenters (#11551)
  Fix Bootsnap configuration (#11483)
  Remove duplication for add questions specs examples (#11559)
  Remove duplication from invites queries (#11552)
  Fix typos and copy-paste errors from comments and examples (#11536)
  Fix conference venues meetings visibility (#11542)
  Add recognition to BrowserStack in the README (#11546)
  Remove unused view hook for `:upcoming_meeting_for_card` (#11543)
  Remove unused dependency: `wicked` (#11150)
  Clean-up initiatives signature URLs and methods (#11545)
  Refactor initiative signing wizard (#10731)
  Fix Permissions screen on budgets throw errors (#11532)
  Redesign: read more literal (#11516)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: budgets type: fix PRs that implement a fix for a bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Permissions screen on budgets throw a 500
2 participants