Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix conference venues meetings visibility #11542

Merged
merged 1 commit into from Aug 31, 2023
Merged

Fix conference venues meetings visibility #11542

merged 1 commit into from Aug 31, 2023

Conversation

alecslupu
Copy link
Contributor

🎩 What? Why?

This PR attempts to fix meeting visibility in conference venues, where all addresses for meetings published, unpublished, transparent are being displayed.

📌 Related Issues

Link your PR to an issue

Testing

  1. Visit a Conference, and check the venues section
  2. Go to admin section, in the meetings component listing
  3. Unpublish all the meetings
  4. Go to frontend and refresh the page
  5. See the Conference Venues and see that addresses are still visible.
  6. Apply patch
  7. See the Conference venues are not being visible

♥️ Thank you!

@alecslupu alecslupu added module: meetings module: conferences type: fix PRs that implement a fix for a bug labels Aug 29, 2023
@alecslupu alecslupu added this to the 0.28.0 milestone Aug 29, 2023
@alecslupu alecslupu marked this pull request as ready for review August 29, 2023 12:56
@alecslupu alecslupu requested a review from a team August 29, 2023 12:57
andreslucena
andreslucena approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽 LGTM

@andreslucena andreslucena merged commit 8449f41 into develop Aug 31, 2023
44 checks passed
@andreslucena andreslucena deleted the fix/meeting-visibility-in-venues branch August 31, 2023 14:09
entantoencuanto added a commit that referenced this pull request Sep 5, 2023
@entantoencuanto
Merge branch 'develop' into feature/redesign-admin
f0e1628 
* develop:
  Remove duplication for add questions specs examples (#11559)
  Remove duplication from invites queries (#11552)
  Fix typos and copy-paste errors from comments and examples (#11536)
  Fix conference venues meetings visibility (#11542)
entantoencuanto added a commit that referenced this pull request Sep 8, 2023
@entantoencuanto
Merge branch 'fix/activities-block-follow-button' into feature/redesi…
e9421e8 
…gn-staging

* fix/activities-block-follow-button: (27 commits)
  Add tests to follow button in processes and assemblies landing page
  Add follow button to participatory spaces last activities content block
  Remove duplication from participatory spaces publications controllers (#11549)
  Fix the a11y tool icons with redesign (#11175)
  Remove duplication from amendments events specs (#11553)
  Remove duplication from elections' user roles forms (#11548)
  Update Node.js from v16.13.0 to v18.17.1 (#11564)
  Remove duplication from stats presenters (#11551)
  Fix Bootsnap configuration (#11483)
  Remove duplication for add questions specs examples (#11559)
  Remove duplication from invites queries (#11552)
  Fix typos and copy-paste errors from comments and examples (#11536)
  Fix conference venues meetings visibility (#11542)
  Add recognition to BrowserStack in the README (#11546)
  Remove unused view hook for `:upcoming_meeting_for_card` (#11543)
  Remove unused dependency: `wicked` (#11150)
  Clean-up initiatives signature URLs and methods (#11545)
  Refactor initiative signing wizard (#10731)
  Fix Permissions screen on budgets throw errors (#11532)
  Redesign: read more literal (#11516)
  ...
This was referenced Nov 2, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreslucena andreslucena andreslucena approved these changes

Assignees
No one assigned
Labels
module: conferences module: meetings type: fix PRs that implement a fix for a bug
Projects
Maintainers' backlog
Archived in project
Milestone
0.28.0
Development

Successfully merging this pull request may close these issues.

Conference venues displays addresses from hidden and moderated meetings
2 participants
@alecslupu @andreslucena