Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos and copy-paste errors from comments and examples #11536

Merged
merged 8 commits into from
Sep 5, 2023
Merged

Fix typos and copy-paste errors from comments and examples #11536

merged 8 commits into from
Sep 5, 2023

Conversation

andreslucena
Copy link
Member

🎩 What? Why?

While reading some code I found a couple of errors in the new Cells comments:

  • "an given" -> it should be "a given"
  • "a Assembly" -> it should be "an Assembly"
  • "Decidim::Budgets::Budget" -> it should be only the model name ("Budget") instead of having the full namespace, just to be consistent with the others comments
  • On the case of one Conference card it wrongly referred to an Assembly
  • On the case of a Process Group it wrongly referred to a Process

So, this PR fixes them.

Testing

All the comments refer to the thing that should refer in a consistent way without grammar errors 🤓

♥️ Thank you!

@andreslucena andreslucena added type: fix PRs that implement a fix for a bug no-backport Pull Requests that should not be backported labels Aug 28, 2023
@andreslucena andreslucena marked this pull request as draft August 28, 2023 15:55
@andreslucena andreslucena marked this pull request as ready for review August 29, 2023 06:08
@andreslucena
Copy link
Member Author

Should we add these to the spell checker? At least with "an" I had some false positives, mostly from "can", but I can probably find a regexp if we want to.

@andreslucena andreslucena changed the title Fix typos and copy paste errors from Cells' comments Fix typos and copy paste errors from comments and examples Aug 29, 2023
@alecslupu alecslupu added this to the 0.28.0 milestone Aug 29, 2023
@andreslucena andreslucena changed the title Fix typos and copy paste errors from comments and examples Fix typos and copy-paste errors from comments and examples Aug 29, 2023
@alecslupu alecslupu requested a review from a team August 29, 2023 07:25
alecslupu
alecslupu requested changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
I have added some comments, let me know your thoughts.

decidim-assemblies/app/serializers/decidim/assemblies/assembly_serializer.rb Outdated Show resolved Hide resolved
decidim-assemblies/lib/decidim/api/assembly_member_type.rb Outdated Show resolved Hide resolved
decidim-assemblies/lib/decidim/api/assembly_type.rb Outdated Show resolved Hide resolved
decidim-assemblies/app/serializers/decidim/assemblies/assembly_importer.rb Outdated Show resolved Hide resolved
decidim-assemblies/lib/decidim/api/assemblies_type_type.rb Outdated Show resolved Hide resolved
...im-participatory_processes/app/cells/decidim/participatory_processes/process_group_l_cell.rb Outdated Show resolved Hide resolved
decidim-participatory_processes/app/cells/decidim/participatory_processes/process_g_cell.rb Outdated Show resolved Hide resolved
...im-participatory_processes/app/cells/decidim/participatory_processes/process_group_s_cell.rb Outdated Show resolved Hide resolved
decidim-participatory_processes/app/cells/decidim/participatory_processes/process_s_cell.rb Outdated Show resolved Hide resolved
decidim-conferences/app/commands/decidim/conferences/admin/destroy_partner.rb Outdated Show resolved Hide resolved
andreslucena and others added 2 commits August 29, 2023 11:31
@andreslucena @alecslupu
Use the name of the class
9d97680 
Suggested by code review

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
@andreslucena @alecslupu
Fix comment for initiatives
7c2aa23 
Suggested by code review

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
alecslupu
alecslupu approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alecslupu alecslupu merged commit 3ab8fde into develop Sep 5, 2023
92 checks passed
@alecslupu alecslupu deleted the fix/cell-comments branch September 5, 2023 07:44
entantoencuanto added a commit that referenced this pull request Sep 5, 2023
@entantoencuanto
Merge branch 'develop' into feature/redesign-admin
f0e1628 
* develop:
  Remove duplication for add questions specs examples (#11559)
  Remove duplication from invites queries (#11552)
  Fix typos and copy-paste errors from comments and examples (#11536)
  Fix conference venues meetings visibility (#11542)
entantoencuanto added a commit that referenced this pull request Sep 8, 2023
@entantoencuanto
Merge branch 'fix/activities-block-follow-button' into feature/redesi…
e9421e8 
…gn-staging

* fix/activities-block-follow-button: (27 commits)
  Add tests to follow button in processes and assemblies landing page
  Add follow button to participatory spaces last activities content block
  Remove duplication from participatory spaces publications controllers (#11549)
  Fix the a11y tool icons with redesign (#11175)
  Remove duplication from amendments events specs (#11553)
  Remove duplication from elections' user roles forms (#11548)
  Update Node.js from v16.13.0 to v18.17.1 (#11564)
  Remove duplication from stats presenters (#11551)
  Fix Bootsnap configuration (#11483)
  Remove duplication for add questions specs examples (#11559)
  Remove duplication from invites queries (#11552)
  Fix typos and copy-paste errors from comments and examples (#11536)
  Fix conference venues meetings visibility (#11542)
  Add recognition to BrowserStack in the README (#11546)
  Remove unused view hook for `:upcoming_meeting_for_card` (#11543)
  Remove unused dependency: `wicked` (#11150)
  Clean-up initiatives signature URLs and methods (#11545)
  Refactor initiative signing wizard (#10731)
  Fix Permissions screen on budgets throw errors (#11532)
  Redesign: read more literal (#11516)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecslupu alecslupu alecslupu approved these changes

Assignees

@alecslupu alecslupu

Labels
no-backport Pull Requests that should not be backported type: fix PRs that implement a fix for a bug
Projects
Maintainers' backlog
Archived in project
Milestone
0.28.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andreslucena @alecslupu