chore(module): add network label with network name #1475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diafour
requested review from
universal-itengineer and
nevermarine
as code owners
diafour
force-pushed
the
chore/module/fix-interfaces-on-vm-dashboard
branch
from
ff47171 to
91e6de0
Compare
- Remove replace to always set network label with "default" value - Add kubevirt patch to set network name from annotation. - Sum all networks on "Network bandwidth usage" graph Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
diafour
force-pushed
the
chore/module/fix-interfaces-on-vm-dashboard
branch
from
1be6552 to
b5090e2
Compare
fl64
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supporting PR: 3p-kubevirt #22 feat(metrics): add network label with network name
Why do we need it, and what problem does it solve?
Given this specs:
Before: only "default" network is shown:
After:
Network bandwidth is summed for all networks:
What is the expected result?
Graph contains separate lines for each network specified in the VM spec.
Checklist