Backport: fix(vm): fix some volume migration bugs #1505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes several critical bugs related to volume migration in VM operations: 1. Fixed Migrating Condition and Generation Sync Problem: Incorrect handling of the Migrating condition and lack of proper synchronization. Solution: Added proper synchronization logic and correct setting of observedGeneration to ensure state consistency. 2. Blocked RWO Volume Migration with Immediate Failure Problem: Attempting to migrate VM with RWO (ReadWriteOnce) volumes was causing undefined behavior. Solution: VMOP now immediately fails the migration operation when RWO volumes are detected, as this configuration is not supported. Added e2e test. 3. Fixed Pending State Hang and Volume Sync on KVVM Problem: VM operations could hang indefinitely in Pending state due to volume synchronization issues on KVVM. Solution: Implemented proper volume synchronization logic to prevent hanging and ensure smooth state transitions. 4. Prevented Unplanned Restarts from Unexpected State Problem: Presence of unexpected state could trigger unplanned VM restarts. Solution: Added validation and handling logic to prevent restarts caused by unexpected state conditions. Signed-off-by: Yaroslav Borbat <yaroslav.borbat@flant.com>
deckhouse-BOaTswain
requested review from
yaroslavborbat and
Isteb4k
as code owners
deckhouse-BOaTswain
deleted the
cherry-pick-release-1.1-36750087407c08e87821d4f98de8e0603cdb5815
branch
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes several critical bugs related to volume migration in VM operations:
1. Fixed Migrating Condition and Generation Sync
Migratingcondition and lack of proper synchronization.observedGenerationto ensure state consistency.2. Blocked RWO Volume Migration with Immediate Failure
3. Fixed Pending State Hang and Volume Sync on KVVM
Pendingstate due to volume synchronization issues on KVVM.4. Prevented Unplanned Restarts from Unexpected State
Why do we need it, and what problem does it solve?
What is the expected result?
Checklist