feat(vi-vd): get newest default StorageClass #499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilrwx
force-pushed
the
feat/vi-vd/get-newest-default-storage-class
branch
3 times, most recently
from
16d86e2 to
15994d9
Compare
yaroslavborbat
requested changes
Nov 5, 2024
images/virtualization-artifact/pkg/controller/service/disk_service.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/service/disk_service.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/service/disk_service.go
Outdated
Show resolved
Hide resolved
danilrwx
force-pushed
the
feat/vi-vd/get-newest-default-storage-class
branch
2 times, most recently
from
2e988d0 to
1ff566b
Compare
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
danilrwx
force-pushed
the
feat/vi-vd/get-newest-default-storage-class
branch
from
c894674 to
d21bc4f
Compare
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
yaroslavborbat
approved these changes
Nov 5, 2024
universal-itengineer
pushed a commit
that referenced
this pull request
Nov 6, 2024
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com> feat(vi-vd): get newest default StorageClass in e2e tests Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com> feat(vi-vd): fix ling errors Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com> feat(vi-vd): fix lint error Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
universal-itengineer
pushed a commit
that referenced
this pull request
Nov 6, 2024
Align the method for getting the default StorageClass with how the default StorageClass is defined in k8s Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Align the method for getting the default StorageClass with how the default StorageClass is defined in k8s
Why do we need it, and what problem does it solve?
Currently if there are multiple default StorageClasses, we take the random one, the behavior in k8s is different, the last annotated default StorageClass is taken
What is the expected result?
Take the last annotated default StorageClass
Checklist