Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[196] Add infinite sliding left discount banner #241

Closed

Conversation

rodrigo-capyba
Copy link

@rodrigo-capyba rodrigo-capyba commented May 20, 2023

Qual a section que voce esta fazendo?

Issue #214

Protótipo versão Desktop
Protótipo versão Mobile
Preview

Checklist

  • Estou usando tokens do DaisyUI e Tailwind CSS
  • Fiz alterações somente no arquivo destinado a section do meu grupo
  • O componente esta editável no admin da Deco
  • Adicionei link de preview da section do admin da deco no PR
  • Minha section funciona com propriedades padrão
  • Adicionei links das variacoes do figma que fiz no PR

@rodrigo-capyba rodrigo-capyba self-assigned this May 20, 2023
@rodrigo-capyba rodrigo-capyba changed the title Add infinite sliding left discount banner [196] Add infinite sliding left discount banner May 20, 2023
@tlgimenes tlgimenes added the Hackathon Hackathon section challange label May 20, 2023
@rodrigo-capyba rodrigo-capyba added the ready-for-review Entregas do hackaton label May 20, 2023
@tlgimenes tlgimenes self-requested a review May 20, 2023 21:20
Copy link
Contributor

@tlgimenes tlgimenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Voce esta prestes a passar para a proxima fase! Por favor faca o comentario para passar para a proxima fase!

@rodrigo-capyba
Copy link
Author

(...) Por favor faca o comentario para passar para a proxima fase!

Que comentário?

@@ -57,6 +57,10 @@ export default {
"--dot-progress": "100%",
},
},
"slideleft": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ola, voce esta quase completando a checklist! Para isso, mova esse slideleft para uma section inline na sua section. Um jeito seria de:

<style dangerouslySetInnerHTML={{__html: '@keyframes {'}} />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hackathon Hackathon section challange ready-for-review Entregas do hackaton
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants