mining: Introduce v2 module. #1831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajohi
approved these changes
Aug 11, 2019
matheusd
approved these changes
Aug 12, 2019
This freezes the root module usage of the mining module by removing the replacement and bumping the required version. This means building the software will still produce binaries based on the v1 module until the v2 module is fully released. All future releases will be moving to version 2 of the module. Consequently, it bumps the required module versions as follows: - github.com/decred/dcrd/blockchain@v1.2.0 - github.com/decred/dcrd/mining@v1.1.1
This udpates the mining module to use the lastest module major versions. The updated direct dependencies are as follows: - github.com/decred/dcrd/blockchain/stake/v2@v2.0.1 - github.com/decred/dcrd/blockchain/v2@v2.0.0 - github.com/decred/dcrd/dcrutil/v2@v2.0.0
davecgh
force-pushed
the
mining_introduce_v2
branch
from
b12fbca
to
ab6f316
Compare
|
@matheusd Thanks, I updated the timestamps to remedy that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make use of
blockchain/v2,blockchain/stake/v2, anddcrutil/v2, a new major version of theminingmodule is required becausemining/v1accepts and returns types from all of them in its API.Consequently, this introduces
mining/v2. A series of individual commits is provided to make the review process easier. Each commit message more thoroughly describes its purpose, but primarily they consist of the following:miningmodule useminingreplace so building the software will still produce binaries based on thev1module until thev2module is fully releasedblockchain/stake/v2@v2.0.1blockchain/v2@v2.0.0dcrutil/v2@v2.0.0v2Finally, it should also be noted that this only introduces the new module and does not update anything to make use of it yet, so building the software will still produce binaries based on the
v1module.