cpuminer: Refactor code to its own package. #2276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 19, 2020
rstaudt2
approved these changes
Jul 19, 2020
dnldd
approved these changes
Jul 19, 2020
davecgh
force-pushed
the
cpuminer_package
branch
from
435ef20
to
2312246
Compare
|
Rebased. Will probably need a couple more as the other go in. |
JoeGruffins
approved these changes
Jul 21, 2020
JoeGruffins
reviewed
Jul 21, 2020
davecgh
force-pushed
the
cpuminer_package
branch
from
2312246
to
d4cae61
Compare
|
@JoeGruffins Good call. Added a skeleton |
dajohi
approved these changes
Jul 23, 2020
This does the minimum work necessary to refactor the CPU miner code into its own internal package. The idea is that separating this code into its own package will improve its testability and ultimately be useful to other parts of the codebase such as the various tests which currently effectively have their own stripped-down versions of this code. The API will certainly need some additional cleanup and changes to make it more usable outside of the specific circumstances it was originally designed to support (namely the generate RPC), however it is better to do that in future commits in order to keep the changeset as small as possible during this refactor. Overview of the major changes: - Create the new package - Move internal/mining/cpuminer.go -> internal/mining/cpuminer/cpuminer.go - Update mining logging to use the new cpuminer package logger - Rename CPUMinerConfig to Config (so it's now cpuminer.Config) - Rename NewCPUMiner to New (so it's now cpuminer.New) - Add exported BestSnapshot method to mining.BlkTmplGenerator - Add exported TxSource method to mining.BlkTmplGenerator - Update all references to the cpuminer to use the package - Add a skeleton README.md - Add a skeleton doc.go
davecgh
force-pushed
the
cpuminer_package
branch
from
d4cae61
to
65da0cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires #2275.
This does the minimum work necessary to refactor the CPU miner code into its own internal package. The idea is that separating this code into its own package will improve its testability and ultimately be useful to other parts of the codebase such as the various tests which currently effectively have their own stripped-down versions of this code.
The API will certainly need some additional cleanup and changes to make it more usable outside of the specific circumstances it was originally designed to support (namely the generate RPC), however it is better to do that in future commits in order to keep the changeset as small as possible during this refactor.
Overview of the major changes:
internal/mining/cpuminer.go->internal/mining/cpuminer/cpuminer.gocpuminerpackage loggerCPUMinerConfigtoConfig(so it's nowcpuminer.Config)NewCPUMinertoNew(so it's nowcpuminer.New)BestSnapshotmethod tomining.BlkTmplGeneratorTxSourcemethod tomining.BlkTmplGeneratorcpuminerto use the packageREADME.mddoc.go