[pi-ui integration] Delete icons.less & fonts.less - provide them using pi-ui's ThemeProvider #2479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amass01
commented
May 2, 2020
amass01
changed the title
|
Need a rebase |
|
Looks like a bunch of updates were made in yarn.lock. Can you make those in a separate PR? |
alexlyp
requested changes
May 7, 2020
alexlyp
approved these changes
May 7, 2020
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff gets rid of icons.less and provide it's content using ThemeProvider instead.
This is also another step towards #2439 which it's main motivation is to fully migrate to css modules and not use
.lessfiles for styling anymore.Also, while migrating the icons, I've found some that aren't used anymore, so I deleted some legacy .svg files.
I've noticed while migrating the icons that we should migrate
fonts.lessat this stage as well, so I extendedThemeProviderto accept array of fonts and provided all fonts we had infonts.lessusingThemeProvider- see this thread for more insights: #2479 (review).Closes #2476