types: Remove Revoked from VSP info response. #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
approved these changes
May 29, 2024
There was a problem hiding this comment.
I'm not sure what process VSP uses for bumping its module majors, but this is a breaking change to the public API and thus necessitates a new major module version.
The way I handle this over in dcrd is by first bumping the major module version to ensure breaking code never makes it into old module versions even when they're pulled by commit hash.
I'm approving since I don't want to hold it up if that's not how you handle module management.
|
Yeah sorry, I was a bit too eager with opening the PR and realized I still needed to make changes. Should be good now. |
Run tests and linters against a hard-coded set of local submodules instead of attempting to find submodules dynamically. While this has the obvious drawback of needing to manually update the list of submodules, it greatly simplifies the script by removing a bunch of regexes and string manipulation. This trade-off seems worthwhile because the list of submodules in this repo will not be something which changes often. This change makes the script less brittle because it is hard-coded to always run against the local code, regardless of any changes to module versionining or project dependencies.
Upcoming changes constitute breaking public API changes to both the client and types modules, therefore this bumps the version numbers of both modules and adds local replacements to go.mod files such that the new versions can be used before they are publicly tagged.
This was marked as deprecated in the previous release and is now being removed.
$ git diff
diff --git a/run_tests.sh b/run_tests.sh
index 40d98c2..ae48f86 100755
--- a/run_tests.sh
+++ b/run_tests.sh
@@ -14,7 +14,7 @@ go version
# Run tests on root module and all submodules.
echo "==> test all modules"
ROOTPKG="github.com/decred/vspd"
-GORACE="halt_on_error=1" go test -race $ROOTPKG/...
+GORACE="halt_on_error=1" go test -race ./... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was marked as deprecated in the previous release and is now being removed.