Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LauncherProfileIcon of furnace becomes NULL when using ProfileManager.toJson() #7

Closed
dusmartijngames opened this issue Jul 25, 2023 · 1 comment · Fixed by #8
Closed

LauncherProfileIcon of furnace becomes NULL when using ProfileManager.toJson() #7

dusmartijngames opened this issue Jul 25, 2023 · 1 comment · Fixed by #8

Comments

@dusmartijngames
Copy link
Contributor

dusmartijngames commented Jul 25, 2023 •
edited
Loading

When using ProfileManager.toJson() my Furnace profile icon becomes Null. This seems to be because of the missing Furnace case in LauncherProfileIcon.GetIcon() and LauncherProfileIcon.GetString()
@dusmartijngames dusmartijngames changed the title LauncherProfileIcon of furnace becomes Bedrock when using ProfileManager.toJson() LauncherProfileIcon of furnace becomes NULL when using ProfileManager.toJson() Jul 25, 2023
@dusmartijngames dusmartijngames mentioned this issue Jul 25, 2023
Merged
@dedepete
Copy link
Owner

Thank you for your contribution! I'm not able to keep up with official launcher's updates so I believe there's quite a few missing icons besides a furnace's one.
Awaiting for the requested change and I will merge your pull request.

dedepete added a commit that referenced this issue Jul 30, 2023
@dedepete
Merge pull request #8 from dusmartijngames/patch-1
a95cd61 
Fixes #7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Patch 1 dusmartijngames/dotMCLauncher
2 participants
@dedepete @dusmartijngames