Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch 1 #8

Merged
merged 4 commits into from
Jul 30, 2023
Merged

Patch 1 #8

merged 4 commits into from
Jul 30, 2023

Conversation

dusmartijngames
Copy link
Contributor

Fixes #7

dedepete
dedepete requested changes Jul 27, 2023
View reviewed changes
Copy link
Owner

@dedepete dedepete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Please fix the problem with the returning value and I will merge this PR.

src/dotMCLauncher.Profiling/LauncherProfileIcon.cs Outdated
@@ -389,7 +393,7 @@ public static string GetString(Icon icon)
case Icon.WOOL:
return "Wool";
default:
return null;
return "Furnace";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave it return null.

@dedepete dedepete merged commit a95cd61 into dedepete:master Jul 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dedepete dedepete dedepete approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LauncherProfileIcon of furnace becomes NULL when using ProfileManager.toJson()
2 participants
@dusmartijngames @dedepete