Skip to content

Conversation

davidvonthenen
Copy link
Contributor

@davidvonthenen davidvonthenen commented Dec 20, 2023

These shouldn't affect the operation of the live client... just more tidy-ing up.

Changes:

  • Changing some logging message
  • Always start the ping thread to allow WS protocol ping but optionally the Deepgram KeepAlive message
  • decrease the amount of protocol level pings to the recommended 20ish seconds
  • throwing exception for unknown message types which is over kill. just log the message type. this allows for new (future/unimplemented) messages from the Deepgram platform to be recognized and provide a warning instead.
  • Clean-up like setting _socket = Null which shouldn't affect operation

Tested using examples and also the test_suite.py

Copy link
Contributor

@lukeocodes lukeocodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@davidvonthenen davidvonthenen merged commit 89eb91a into deepgram:main Dec 20, 2023
@davidvonthenen davidvonthenen deleted the live-ping-clean-up branch December 20, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants