Skip to content

fix:issue of exception on websocket closing #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 17, 2024
Merged

fix:issue of exception on websocket closing #256

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdbc10a
fix:issue of exception on websocket closing
SandraRodgers Jan 16, 2024
f4610f6
added exception for non 1000 errors
SandraRodgers Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions deepgram/clients/live/v1/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
# SPDX-License-Identifier: MIT
import json
from websockets.sync.client import connect
import websockets
import threading
import time
import logging, verboselogs
Expand Down Expand Up @@ -191,22 +192,34 @@ def _listening(self) -> None:
data,
)

except Exception as e:
except websockets.exceptions.ConnectionClosedOK as e:
if e.code == 1000:
self.logger.notice("_listening(1000) exiting gracefully")
self.logger.debug("LiveClient._listening LEAVE")
return
else:
error: ErrorResponse = {
"type": "Exception",
"description": "Unknown error _listening",
"message": f"{e}",
"variant": "",
}
self.logger.error(f"WebSocket connection closed with code {e.code}: {e.reason}")
self._emit(LiveTranscriptionEvents.Error, error)
self.logger.debug("LiveClient._listening LEAVE")
raise

except Exception as e:
error: ErrorResponse = {
"type": "Exception",
"description": "Unknown error _listening",
"message": f"{e}",
"variant": "",
}
self._emit(LiveTranscriptionEvents.Error, error)

self.logger.error("Exception in _listening: %s", str(e))
self.logger.debug("LiveClient._listening LEAVE")
raise

def _processing(self) -> None:
self.logger.debug("LiveClient._processing ENTER")
Expand Down