Skip to content

Conversation

davidvonthenen
Copy link
Contributor

@davidvonthenen davidvonthenen commented Jan 25, 2024

Proposed changes

This accepts any number of parameters that might be passed in when someone uses the v3 SDK with v2 code.

Threw in some logging changes as well that were in my queue to get into the next PR.

Types of changes

What types of changes does your code introduce to the community Python SDK?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update or tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have lint'ed all of my code using repo standards
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

NA

@davidvonthenen davidvonthenen merged commit 6b56474 into deepgram:main Jan 26, 2024
@davidvonthenen davidvonthenen deleted the update-fatal-error-on-old-class branch January 26, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants