Skip to content

Conversation

SandraRodgers
Copy link
Contributor

Proposed changes

The warning that numerals will be deprecated isn't accurate (I believe). It was the feature numbers that was deprecated, but numerals will not be deprecated.

Types of changes

What types of changes does your code introduce to the community Python SDK?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update or tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have lint'ed all of my code using repo standards
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link
Contributor

@davidvonthenen davidvonthenen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might not see the README merge conflict because the diff isn't rendering because the changes are large.

@SandraRodgers SandraRodgers force-pushed the sr/remove-numerals-warning branch from d10ee73 to 6ef3b38 Compare January 25, 2024 21:09
@SandraRodgers SandraRodgers merged commit 522e87d into main Jan 25, 2024
@SandraRodgers SandraRodgers deleted the sr/remove-numerals-warning branch January 25, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants