Skip to content

Conversation

davidvonthenen
Copy link
Contributor

@davidvonthenen davidvonthenen commented Feb 14, 2024

Proposed changes

Addresses issue submitted by @leddy231 : #294

This also addresses:

  • implements __str__ to provide a better print() experience
  • fixes a serialization issue on empty objects which was causing an exception: if _dict["intents_info"] is not None: -> if "intents_info" in _dict:
  • fix missing sentiment segments:
if "sentiment" in _dict:
    _dict["sentiment"] = Sentiment.from_dict(_dict["sentiment"])
  • Some fields like speaker, speaker_confidence, etc needed to be excluded from the JSON when not set
  • Did an oops where .items() should only be used on Dict[] objects (this is the reported issue)

Types of changes

What types of changes does your code introduce to the community Python SDK?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update or tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have lint'ed all of my code using repo standards
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@davidvonthenen davidvonthenen merged commit a1ca02b into deepgram:main Feb 14, 2024
@davidvonthenen davidvonthenen deleted the implement-dict-for-response branch February 14, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants