-
Notifications
You must be signed in to change notification settings - Fork 104
fix: adds inject agent message method #555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA new Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant AgentWebSocketClient
participant WebSocket
User->>AgentWebSocketClient: inject_agent_message(options)
AgentWebSocketClient->>AgentWebSocketClient: Validate options type
AgentWebSocketClient->>WebSocket: send(str(options))
WebSocket-->>AgentWebSocketClient: Send result (success/failure)
AgentWebSocketClient-->>User: Return True/False
sequenceDiagram
participant User
participant AsyncAgentWebSocketClient
participant WebSocket
User->>AsyncAgentWebSocketClient: await inject_agent_message(options)
AsyncAgentWebSocketClient->>AsyncAgentWebSocketClient: Validate options type
AsyncAgentWebSocketClient->>WebSocket: await send(str(options))
WebSocket-->>AsyncAgentWebSocketClient: Send result (success/failure)
AsyncAgentWebSocketClient-->>User: Return True/False
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Pylint (3.3.7)deepgram/clients/agent/v1/websocket/async_client.pydeepgram/clients/agent/v1/websocket/client.pytests/unit_test/test_unit_agent_inject_agent_message.py📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🧰 Additional context used🧠 Learnings (4)📓 Common learnings
deepgram/clients/agent/v1/websocket/async_client.py (4)
deepgram/clients/agent/v1/websocket/client.py (6)
tests/unit_test/test_unit_agent_inject_agent_message.py (2)
🧬 Code Graph Analysis (2)deepgram/clients/agent/v1/websocket/async_client.py (4)
deepgram/clients/agent/v1/websocket/client.py (3)
🔇 Additional comments (3)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
fixes #553
Summary of Changes Made:
1. Fixed Missing Method Implementation
inject_agent_message()
method to sync client (client.py
)inject_agent_message()
method to async client (async_client.py
)inject_user_message()
2. Created Comprehensive Unit Tests
3. Verified Complete Functionality
Test Results:
Types of changes
What types of changes does your code introduce to the community Python SDK?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Summary by CodeRabbit
New Features
Tests