added timeout parameter for prerecorded requests #89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of our users needs to override the default timeout for HTTPS requests to Deepgram. Currently the SDK uses the underlying libraries' default timeouts. For
aiohttp
/asyncio
the default timeout is 5 minutes, and forurllib
the default timeout is undefined.This PR allows the user to override the default timeout, which can be useful for transcribing large files that require significant upload time.
One thing I don't like is that
aiohttp
andurllib
treat timeouts differently.aiohttp
includes the file upload time in the timeout, whereasurllib
does not. This makes the timeout parameter slightly different for thedeepgram.transcription.prerecorded
anddeepgram.transcription.sync_prerecorded
methods. Thoughts?Link to GH discussion: https://github.com/orgs/deepgram/discussions/160