Move dependencies for examples to dev-dependencies #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcaden
changed the title
|
Feel free to ignore or suppress the clippy errors, as they are non-critical and new with the latest rust release. We will resolve them soon, but do note that we have some transitive dependencies specified to satisfy minimal-versions checks, and those should not be removed. |
|
I fixed clippy errors on this PR #115 |
They are only used in the examples, there is no need for the library users to include them. pkg-config is only required while building audio, it is moved to.dev-dependencies as well
jcaden
force-pushed
the
move_dependencies_to_dev
branch
from
06410e8 to
da242b7
Compare
|
I modified the patches. I tested locally all the test that failed and seems to work now. |
jcdyer
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some dependencies that the users of the library don't need as they are only used in examples, moving them to dev-dependencies makes the examples work while they are not included as part of the library.
This PR is also removing some unused dependencies from Cargo.toml