-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic embed widget iframe #1629
Closed
mattrunyon opened this issue
Nov 7, 2023
· 0 comments
· Fixed by #1668 or deephaven/deephaven-core#4930
Closed
Generic embed widget iframe #1629
mattrunyon opened this issue
Nov 7, 2023
· 0 comments
· Fixed by #1668 or deephaven/deephaven-core#4930
Comments
mofojed
added a commit
to mofojed/web-client-ui
that referenced
this issue
Dec 6, 2023
- Loads the widget - Fixes deephaven#1629
mofojed
added a commit
to mofojed/web-client-ui
that referenced
this issue
Dec 6, 2023
- Loads the widget and displays it if there is a widget plugin that matches - Displays an error if no plugin is found that can display the type of widget, or a widget with that name is not found - Fixes deephaven#1629
Merged
mofojed
added a commit
that referenced
this issue
Dec 7, 2023
- Loads the widget and displays it if there is a widget plugin that matches - Displays an error if no plugin is found that can display the type of widget, or a widget with that name is not found - Fixes #1629 Tested by installing the matplotlib, plotly-express python plugins, but only installing the plotly-express JS plugin (not the matplotlib JS plugin). Then ran the following snippet: ```python from deephaven.column import int_col, string_col from deephaven.plot import Figure, express as dx from deephaven import new_table import matplotlib.pyplot as plt t = new_table([ string_col("Categories", ["A", "B", "C"]), int_col("Values", [1, 3, 5]), ]) t_rollup = t.rollup(aggs=[], by=["Categories"], include_constituents=True) fig = Figure().plot_cat(series_name="Test", t=t, category="Categories", y="Values").show() dx_fig = dx.bar(table=t, x="Categories", y="Values") import matplotlib.pyplot as plt mpl_fig = plt.figure() ax = mpl_fig.subplots() ax.plot([1, 2, 3, 4], [4, 2, 6, 7]) ``` Then opened up pages to the following URLs to make sure the appeared correctly: 1. http://localhost:4030/?name=t - Table displayed correctly 2. http://localhost:4030/?name=t_rollup - Tree Table displayed correctly 3. http://localhost:4030/?name=fig - Deephaven Figure displayed correctly 4. http://localhost:4030/?name=dx_fig - Plotly-express figure displayed correctly 5. http://localhost:4030/?name=mpl_fig - Error displayed correctly about unknown type 6. http://localhost:4030/?name=err - Timeout error displayed 7. http://localhost:4030/ - Error saying no name provided --------- Co-authored-by: Matthew Runyon <mattrunyonstuff@gmail.com>
mofojed
pushed a commit
to deephaven/deephaven-core
that referenced
this issue
Dec 11, 2023
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.56.0 # [0.56.0](deephaven/web-client-ui@v0.55.0...v0.56.0) (2023-12-11) ### Bug Fixes * add right margin to <Button kind='inline'/> using icons ([#1664](deephaven/web-client-ui#1664)) ([fd8a6c6](deephaven/web-client-ui@fd8a6c6)) * adjust filter bar colour ([#1666](deephaven/web-client-ui#1666)) ([4c0200e](deephaven/web-client-ui@4c0200e)) * convert organize columns component to purecomponent ([#1653](deephaven/web-client-ui#1653)) ([8ddc114](deephaven/web-client-ui@8ddc114)), closes [#1650](deephaven/web-client-ui#1650) * Default to `Skip` operation instead of `Sum` operation ([#1648](deephaven/web-client-ui#1648)) ([6083173](deephaven/web-client-ui@6083173)), closes [#1355](deephaven/web-client-ui#1355) [#1355](deephaven/web-client-ui#1355) * Fix button snapshots ([#1655](deephaven/web-client-ui#1655)) ([c0cc966](deephaven/web-client-ui@c0cc966)) * popper blur in styleguide ([#1672](deephaven/web-client-ui#1672)) ([6fa2204](deephaven/web-client-ui@6fa2204)) * Unable to delete selected rows in some input tables ([#1678](deephaven/web-client-ui#1678)) ([1e71550](deephaven/web-client-ui@1e71550)), closes [#1677](deephaven/web-client-ui#1677) ### Features * Add embed-widget ([#1668](deephaven/web-client-ui#1668)) ([1b06675](deephaven/web-client-ui@1b06675)), closes [#1629](deephaven/web-client-ui#1629) * forward and back button for organize column search ([#1641](deephaven/web-client-ui#1641)) ([89f2be5](deephaven/web-client-ui@89f2be5)), closes [#1529](deephaven/web-client-ui#1529) * Tables that have names starting with underscore do not auto-launch from console ([#1656](deephaven/web-client-ui#1656)) ([21131fe](deephaven/web-client-ui@21131fe)), closes [#1549](deephaven/web-client-ui#1549) [#1410](deephaven/web-client-ui#1410) * theme fontawesome icon size wrapped in spectrum icons ([#1658](deephaven/web-client-ui#1658)) ([2aa8cef](deephaven/web-client-ui@2aa8cef)) * Theme Selector ([#1661](deephaven/web-client-ui#1661)) ([5e2be64](deephaven/web-client-ui@5e2be64)), closes [#1660](deephaven/web-client-ui#1660) * Theming - Bootstrap ([#1603](deephaven/web-client-ui#1603)) ([88bcae0](deephaven/web-client-ui@88bcae0)) * Theming - Inline svgs ([#1651](deephaven/web-client-ui#1651)) ([1e40d3e](deephaven/web-client-ui@1e40d3e)) * View cell contents in context menu ([#1657](deephaven/web-client-ui#1657)) ([90b7517](deephaven/web-client-ui@90b7517)), closes [#1605](deephaven/web-client-ui#1605) ### BREAKING CHANGES * Bootstrap color variables are now predominantly hsl based. SCSS will need to be updated accordingly. Theme providers are needed to load themes. * Tables assigned to variable beginning with "_" will not open automatically even if "Auto Launch Panels" is checked. Co-authored-by: deephaven-internal <deephaven-internal@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We need a generic embed widget handler that can take a widget name (and optional type) and display it. This will help w/ dashboard creation in Deephaven UI (open in separate tab) and should also help with Jupyter widgets.
The text was updated successfully, but these errors were encountered: