Skip to content

PassThroughTrackTranscoder supports not checking MediaFormatValidator #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2019

Conversation

Satsrag
Copy link

@Satsrag Satsrag commented Jul 26, 2019

Thanks for your sharing. I use this feature in my project. If it is not used here, refuse it.

  • PassThroughTrackTranscoder copy track to output mp4 container. The mimetype of mp4 track is more than just a video/avc, there are other mimetypes. For example, video/hevc, video/mp 4v-es... and so on. So PassThroughTrackTranscoder#getDeterminedFormat() returns null to prevent checking MediaFormatValidator.

@natario1
Copy link
Member

I think this makes sense but can't accept the way it's done - we have removed this listener a few commits ago and we don't want to reintroduce it.

You could remove all these commits and add a boolean to TranscoderMuxer.setOutputFormat:

public void setOutputFormat(@NonNull TrackType trackType, @NonNull MediaFormat format, boolean needsValidation)

@Satsrag
Copy link
Author

Satsrag commented Jul 29, 2019

add a boolean to TranscoderMuxer.setOutputFormat

   * TaskFuture#cancel will call Thread#interrupt. Thread#interrupt throw InterruptedException only when thread is bloking. So other situation can't stop transcode.
@natario1 natario1 merged commit 849ef27 into deepmedia:master Aug 2, 2019
@natario1
Copy link
Member

natario1 commented Aug 2, 2019

Thank you @Saqrag !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants