Skip to content

Enable multiple video tracks with no audio. #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

cbernier
Copy link
Contributor

There's always a number of audio sources equal to the number of video sources (TranscoderOptions.java:131)
and getTrackFormat returns null when the video file had no audio track or vice versa.
So when getTrackFormat returns null for all sources we can remove the associated track
type.

If only some of the data source files have no audio or video sources then it will still throw
an exception because we can't build a valid stream with missing parts.: it is either a full
track or no track.

@cbernier
Copy link
Contributor Author

cbernier commented Feb 18, 2020

If only some of the data source files have no audio or video sources then it will still throw
an exception because we can't build a valid stream with missing parts.: it is either a full
track or no track.

I am currently looking to fix this exception for the audio track by filling the missing parts with a muted sound: https://github.com/natario1/Transcoder/issues/51#issuecomment-587570954

@natario1
Copy link
Member

Thanks @cbernier2 ! Wouldn't TrackStatus.ABSENT be a better choice? Literally none of the input file have this track type so... I'd say it's absent. It would also be consistent with the single file case.

@cbernier
Copy link
Contributor Author

Thanks @cbernier2 ! Wouldn't TrackStatus.ABSENT be a better choice? Literally none of the input file have this track type so... I'd say it's absent. It would also be consistent with the single file case.

Yes, indeed, I change that.

There's always a number of audio sources equal to the number of video sources (TranscoderOptions.java:131)
and getTrackFormat returns null when the video file had no audio track or vice versa.
So when getTrackFormat  returns null for all sources we can remove the associated track
type.

If only some of the data source files have no audio or video sources then it will still throw
an exception because we can't build a valid stream with missing parts.: it is either a full
track or no track.
@natario1 natario1 merged commit 414f733 into deepmedia:master Feb 19, 2020
@natario1
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants