add SGE class in pbs.py #323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #323 +/- ##
===========================================
- Coverage 72.80% 55.99% -16.81%
===========================================
Files 37 37
Lines 3603 3659 +56
===========================================
- Hits 2623 2049 -574
- Misses 980 1610 +630 ☔ View full report in Codecov by Sentry. |
njzjz
reviewed
Apr 14, 2023
dpdispatcher/pbs.py
Outdated
| status_line = txt | ||
| print("status_line", status_line) | ||
| self.status_record_list.append(status_line) | ||
| if (status_line is None) and (self.status_record_list != []): |
There was a problem hiding this comment.
It seems that self.status_record_list != [] can be removed as self.status_record_list must not be [] due to line 227.
By the way, what is status_record_list used for?
There was a problem hiding this comment.
I used status_record_list for debugging purpose. Will fix it according to your suggestion.
njzjz
approved these changes
Dec 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This SGE class inherit from PBS machine class. I have tested with a vanilla python print job and it works. I can continue working on testing with more complex tasks.