fix: add tags trigger to release workflow to enable tag-based releases #544
+2
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release workflow was broken after #537 added
branches-ignore
to prevent running on bot branches. While this successfully prevented unnecessary runs oncopilot/**
,dependabot/**
, andpre-commit-ci-update-config
branches, it inadvertently prevented the workflow from running on tag pushes.The issue occurs because GitHub Actions treats tag pushes differently from branch pushes. When using
branches-ignore
without an explicittags
section, the workflow will only trigger on branch pushes (excluding the ignored ones) and pull requests, but not on tag pushes.The
release.yml
workflow has a conditionif: github.event_name == 'push' && startsWith(github.ref, 'refs/tags')
indicating it's designed to run on tag pushes, but without the proper trigger configuration, it never gets the chance to execute.This fix adds an explicit
tags
trigger to the workflow:This follows the same pattern used in:
ci-docker.yml
andpublish_conda.yml
) that already correctly trigger on tagsThe workflow will now run on:
v*
pattern (e.g.,v1.0.0
,v2.1.3
)The PyPI publishing step will only execute when the workflow is triggered by a tag push, as intended by the existing condition.
Fixes #543.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
39.106.xx.xx
python -m coverage run -p --source=./dpdispatcher -m unittest -v
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.