fix: Replace rsync -az with -rlptDz to avoid permission issues #547
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rsync function was using the
-a
(archive) flag which includes-o
(preserve owner) and-g
(preserve group) options that require superuser privileges to change file ownership. This caused "Operation not permitted" errors when downloading files from remote systems to local environments where users lack such privileges.Problem:
Root Cause:
The
-a
flag is equivalent to-rlptgoD
, where-o
(preserve owner) and-g
(preserve group) cause permission issues on systems where users cannot change file ownership.Solution:
Replace
-az
with-rlptDz
to maintain all useful archive functionality while excluding the problematic owner and group preservation options:-r
: recursive-l
: copy symlinks as symlinks-p
: preserve permissions-t
: preserve modification times-D
: preserve device files and special files-z
: compress during transferChanges:
dpdispatcher/utils/utils.py
to use-rlptDz
flags instead of-az
tests/test_rsync_flags.py
Testing:
Fixes #434.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.