Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

very slow with 380 to 390 rules #644

Closed
morganholly opened this issue Mar 21, 2022 · 15 comments
Closed

very slow with 380 to 390 rules #644

morganholly opened this issue Mar 21, 2022 · 15 comments
Assignees
Milestone

Comments

@morganholly
Copy link

if my counting is correct, 351 enabled and 9 disabled on one intgrid layer, and 25 on another intgrid layer. i have a large level for testing all the rules, i had made a small level for seeing it on a realistic map, and i created a large one that i was going to use for procedurally pasting smaller rooms within in godot. over time it has slowed down noticeably and at this point is basically unusable, even with the autotile rendering off. i'm ok with it taking time to preview with the autotiling, but having a way to draw in maps with that turned off that was more performant would be much appreciated. additionally it would have a significant bit of lag when reordering groups.

@morganholly
Copy link
Author

i am on 0.9.3 on macos catalina 10.15.7 (19H1715). i do not think it is a hardware issue, this is a 2019 high end macbook pro

@morganholly
Copy link
Author

basically i'd like a mode where i draw in the intgrid values and then manually have it autotile it

@deepnight
Copy link
Owner

deepnight commented Mar 25, 2022

Thanks for reporting the problem!
I have some reworks to be done on then "rendering" side of the app, specifically with AutoLayer rules, which tend to be super slow when you have many ones.

In 1.0 beta 7, the undo/redo was rewritten completely and is about 50 times faster for complex maps. I've also optimized lots of things in 1.0, so this will probably help. Unfortunately, there's no macOS beta for now, only a Win build.

So it would help me a lot if you could send me a copy of your current LDtk project, if you're ok with that. I won't redistribute anything, it's only to have a good example of the "target".

You can email me: ldtk at deepnight dot net

@deepnight deepnight self-assigned this Mar 25, 2022
@deepnight deepnight added this to the 1.0.0-rc1 milestone Mar 25, 2022
@deepnight deepnight added the ❓ Need info/testing Further information is requested label Mar 25, 2022
@morganholly
Copy link
Author

ok i sent an email, hopefully that helps you with optimization

@deepnight
Copy link
Owner

I found some culprit for the rules performance issues. Here is a before/after optimization gif:
compare

You should have much better perfs in next update. I will upload a new beta soon for you to test that.

@deepnight
Copy link
Owner

You can check Beta 8 here: https://ldtk.io/files/beta

Please tell me if things are better for your project.

@morganholly
Copy link
Author

morganholly commented Mar 28, 2022 via email

@deepnight
Copy link
Owner

@morganholly
Is this issue fixed for you?

@morganholly
Copy link
Author

morganholly commented Apr 3, 2022 via email

@deepnight
Copy link
Owner

deepnight commented Apr 3, 2022

So it looks like the beta zip only contained a windows installer. I’m on mac so I unfortunately can’t try out the beta with the current download link Thanks, Morgan

The 1.1 update is out, with macOS support :) You can download it here: https://ldtk.io

@morganholly
Copy link
Author

morganholly commented Oct 11, 2022 via email

@morganholly
Copy link
Author

morganholly commented Oct 11, 2022 via email

@deepnight
Copy link
Owner

Related #8

@deepnight
Copy link
Owner

Related #984

@deepnight
Copy link
Owner

Things should now run smoother, closing this for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants