fix: ignore_case in pattern_matching_skill #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoptar
reviewed
Sep 25, 2018
| self.regex = regex | ||
| self.ignore_case = ignore_case | ||
| if self.ignore_case and (patterns is not None): | ||
| patterns = [pattern.lower() for pattern in patterns] |
There was a problem hiding this comment.
this can mess up uppercase metacharacters in regular expressions
yoptar
approved these changes
Sep 25, 2018
seliverstov
approved these changes
Sep 25, 2018
surkovv
pushed a commit
to surkovv/DeepPavlov
that referenced
this pull request
Aug 24, 2022
* fix: ignore_case in pattern_matching_skill * fix: do not lowercase None pattern * fix: lowecase only nonregex patterns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PatternMatchingSkilldidn't work correctly withignore_case=Truewhenpatternscontained non lower-cased words.