Repository navigation
Feature request: let permission presets carry their own icon #1035
Letter2025
started this conversation in
Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
I maintain a community plugin (
dsh-approval-llm, a model-based approval answerer) that adds a custom permission preset (model-approval, "帮我批准") through its bundle patch. The preset options show up in the Access chip and the/permissionpicker, but there is no way to give the preset an icon.The icon table
permissionGlyphsinpackages/client/ui-conversation/src/client/skeleton/PermissionSelect.tsxis hardcoded to four preset values, and thepermissionsprojection typePresetOptioncarries onlyvalue/name/description— no icon field crosses the wire. So a deployment can add any preset name to the table, but its icon is locked into harness source.Proposal: add an extension point so a preset can declare its own glyph — e.g. an optional
icononPresetOption(a glyph name or SVG data resolved from the preset table), rendered by the Access chip and the picker, falling back to the current four-value table and then to no icon. That keeps the design set for built-ins while making custom presets self-contained.Happy to help with the implementation once the direction is agreed.
All reactions