Repository navigation
Replies: 1 comment
|
Additional verification is now complete in an actual isolated Windows installation of the locally fixed build. Starting with a synthetic legacy flow-style profile, the normal Settings form successfully created a custom provider, saved it, reopened the saved form, and restored it after a normal Desktop exit/restart. The existing Unicode model entries, their explicit test capacities, comments, and unrelated configuration were retained. The loopback model stub received zero requests during this save/reopen test. This verifies the configuration-editing path; it does not claim a live GLM API call or an upstream release containing the fix. |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Adding a provider in Settings can fail before any model API request, even though the same profile starts successfully. I encountered this while adding GLM; the reproducer below contains no provider credentials and shows that the failure is in local configuration editing.
Version and parser difference
Reproduced against
dsh-v0.2.2-alpha.2(f3803c96974ad4a94195fb97e5c637e9c2a3afe3), withjs-yaml 4.3.2andyaml 2.9.0.Profile loading uses
js-yamlwith the profile schema.packages/boot/config-editor/src/index.tsparses the same source withyaml.parseDocument()before saving an edit. A nested flow collection with an under-indented closing delimiter is accepted by the former but rejected by the latter withBAD_INDENT/ “Flow sequence in block collection must be sufficiently indented and end with a ]”.Synthetic minimal reproduction
This example is constructed from scratch; it is not a fragment of a real user profile.
With the two dependencies installed, run:
For an existing profile containing this syntax, startup can succeed, but a Settings edit that persists through ConfigEditor fails while parsing the existing patch. No GLM/OpenAI/Anthropic request is needed to trigger it. Indenting the closing
]resolves this minimal example, but asking users to rewrite entire provider configurations risks losing unrelated fields and comments.Locally verified fix behavior
A local fix now handles this specific compatibility case before editing:
BAD_INDENT, after confirming that the lexer sees a real flow-closing token. Brackets inside quoted strings and block scalars are not treated as delimiters.Regression verification: 4 configuration test files / 42 tests passed, including real Loader save/restart, JSON and YAML, Unicode and multiple model entries, comment and unrelated-row preservation, and failed-write safeguards. The full build/type-check pipeline also passed 10/10 gates. These are local test results; they do not assert a successful live GLM API call or an upstream release containing the fix.
Could the configuration editor share the runtime's accepted syntax contract, or add this narrow, semantics-checked compatibility path? The important user-facing behavior is that a runtime-valid existing profile remains editable without discarding its content.
All reactions