[Bug] Silent update wipes resources/runtime/office-skills when resources/app contains a junction（静默更新后应用无法启动）

[EvanZhhh]

issue-report.md

Summary / 摘要

On Windows, a silent update (--updated /S --force-run) exits with code 0 but leaves resources\runtime\office-skills empty. The next launch dies with DesktopHostFatalError: ENOENT ... office-skills\office\SKILL.md and the app never starts.

Root cause: the installer clears the legacy resources\app directory following a directory junction inside it, deleting the freshly unpacked resources\runtime contents.

中文摘要：静默更新返回 0，但 resources\runtime\office-skills 被清空，下次启动直接 ENOENT 崩掉、应用打不开。根因是安装器清理 resources\app 时穿透了里面的 junction， 把刚解包的 runtime 一起删了。

Environment

item | value -- | -- App | @deepseek-ai/dsh-desktop 0.2.1-rc.5 (dshBuildCommit d4db512a…) OS | Windows 11 Pro x64 (zh-CN) Electron / Node | 44.7.0 / 24.21.0 Update feed | https://download.deepseek.com/dsh-desk/feeds/win-x64/ (nightly) Install | per-user (HKCU uninstall entry), D:\DeepSeek_harness Installer | deepseek-harness-0.2.1-rc.5-win-x64.exe (289 MB, electron-builder NSIS)

Experiment 5 used a 2-file fake directory (a package.json and one junction). Nothing from the plugin was running. That isolates the junction as the trigger.

Probe files placed inside resources\runtime, office-skills and app.asar.unpacked disappeared in every run where the installer executed, confirming the installer clears these directories before unpacking.

Why the failure is invisible / 为什么难发现

• /S suppresses all UI; a failed or partial unpack produces no prompt at all.
• The installer still exits 0, so electron-updater reports success.
• The crash message says “application files are missing or damaged … reinstall”, which points the user at reinstall instead of at the update path.
• Reinstalling by double-clicking the same installer always works, because by then the resources\app directory is already gone — so it looks like “update is broken, reinstall fixes it”.

Official update journal / 官方更新日志

With DSH_DESKTOP_UPDATE_JOURNAL_DIR set, a failing run records:

json

{"event":"started","time":"...T14:12:21.523Z","pid":28888}
{"event":"state","phase":"idle"}
{"event":"workspace-failed","time":"...T14:12:23.703Z"}
{"event":"quit-requested","time":"...T14:12:50.355Z"}

and a successful run after removing the junction:

json

{"event":"started","pid":27472}
{"event":"state","phase":"idle"}
{"event":"workspace-ready","time":"...T14:18:59.606Z"}

Suggested fixes / 建议修复

1. Installer (primary). When clearing the legacy resources\app directory, do not recurse into reparse points. Check FILE_ATTRIBUTE_REPARSE_POINT (GetFileAttributesW / FindFirstFile dwFileAttributes) and delete the link itself with RemoveDirectory instead of following it. NSIS RMDir /r follows junctions by default — this is the classic pitfall. A safer order is: unpack first, then remove the legacy directory, or remove the legacy directory before unpacking and never touch resources\runtime from that cleanup path.

2. Host (defence in depth). @deepseek-ai/dsh-skill-office/lib/index.js reads every SKILL.md with a bare readFileSync inside SKILL_NAMES.map:

   js

   const { description } = parseSkill(readFileSync(path, 'utf8'), path);

   A single missing file throws and becomes DesktopHostFatalError, taking the whole app down. Two cheap mitigations:

   • skip a skill whose SKILL.md is missing instead of throwing;
   • fall back to the copy that is already bundled inside app.asar (dsh/node_modules/@deepseek-ai/dsh-skill-office/assets/…) when assetRoot does not contain the expected files. The identical 8 files ship in both places today, so the fallback is free.

Impact / 影响面

Any third-party plugin that unpacks app.asar into resources\app (a common technique for patching the client) leaves a junction there, and then every subsequent silent update bricks the app until the user manually reinstalls. Because the installer reports success, this is effectively silent data loss inside the installation directory.

Workaround for users / 用户侧规避

Before updating, quit the app and remove resources\app (delete the junction itself first, never recurse into it). After doing that, both --updated /S --force-run and the in-app updater complete normally.

[EvanZhhh]

最小复现：5 行即可复现

$res = 'D:\DeepSeek_harness\resources'
New-Item -ItemType Directory -Path "$res\app" -Force
'{"name":"@deepseek-ai/dsh-desktop","version":"0.2.1-rc.5","main":"lib/main.js","type":"module"}' | Set-Content "$res\app\package.json"
New-Item -ItemType Junction -Path "$res\app\runtime" -Target "$res\runtime"
Start-Process '.exe' -ArgumentList '--updated','/S','--force-run' -Wait

ExitCode=0，但 resources\runtime\office-skills 变成 0 个文件