Repository navigation
Replies: 1 comment 1 reply
|
That reason text comes from the reviewer, not the harness. Everything after A missing or ambiguous pending PTC record takes a different path: For an inner call the pending entry is appended last, after the surface walk: That leaves two candidates, and the card cannot separate them: the reviewer received the right tail and classified it wrong, or something in the same process rewrote the review request. You already have one candidate in that path, the plugin's If it reproduces without the plugin, the useful report is: session id, the three approval events with |
Uh oh!
There was an error while loading. Please reload this page.
Reporter: MCviseron
Date: 2026-11-10
Severity: Medium
Reproducibility: Often
Summary
On DSH 0.2.2-rc.1 with the Auto permission preset, Auto review intermittently rejects PTC inner tool calls (tools invoked from inside
run_code, for examplegrep,read, orpwsh) with the reason that no pending tool call was supplied. The reviewer appears to receive a history ending with a user instruction, so the actual pending action cannot be classified.Expected Behavior
Auto review should receive the pending PTC inner call as the final review item, classify that exact action, and return a normal allow/deny decision. If the action is allowed, the PTC tool call should execute without an unrelated "no pending tool call" rejection.
Actual Behavior
The approval card shows an Auto review denial whose reason says the final item is a user instruction rather than the pending tool call. The inner call is not executed until the user manually selects 允许一次.
The failure was observed for PTC calls with call IDs ending in
:ptc:1; the outerrun_codetransport is excluded by design, but the inner call should still be reviewed.Reproduction Steps
Prerequisites: DSH Desktop
0.2.2-rc.1(nightly), Auto review0.2.2-rc.1, the Auto permission preset selected, and a session with a long history (the observed sessions had roughly 1,000+ logged events).run_code, for example:tools.read/tools.pwshthe same way.grep/read/pwshcall, the reviewer denies it with "No pending tool call was supplied to review; the final item is a user instruction".Minimal Reproduction (if applicable)
The smallest observed form is a PTC inner call under Auto review in a long session:
The same failure was observed with
tools.readandtools.pwsh. A manual 允许一次 lets the call run, so the underlying tool itself is reachable.Environment
0.2.2-rc.1(nightly)@deepseek-ai/dsh-experimental-auto-review0.2.2-rc.1dsh-mcviseron-plugin0.7.2(its Auto review integration only appends a Chinese display translation)Error Output
Exact approval reason observed at 2026-11-10T11:32:09.346Z:
Other exact reasons observed in the same session:
Relevant approval events:
Visual Evidence
The supplied screenshot shows the approval card titled 等待审批 with the exact English denial reason above and the plugin-appended Chinese translation block. It has no tool-specific action details because the reviewer denied before classifying the action; the call is only recoverable through 允许一次.
Impact
run_code; observed in long sessions.Related Files
D:/DeepSeek Harness/resources/app.asar/dsh/node_modules/@deepseek-ai/dsh-experimental-auto-review/lib/index.jssnapshotAutoReview,reviewMessages, and PTC branch that should append the pending call.D:/DeepSeek Harness/resources/app.asar/dsh/node_modules/@deepseek-ai/dsh-tools/**...:ptc:N).D:/Program/DSH-Plugin-Class/dsh-mcviseron-plugin/src/components/auto-review-fix/review-context.tsFILTERED_HISTORY/PENDING_ACTIONshape and does not modify the 0.2.2 multi-message review request; included for investigator context, not as an asserted cause.Notes
...:ptc:1), not on the outerrun_codecall. The reviewer message says the final item is a user instruction, which suggests the pending PTC entry is absent from the reviewer's message list, but this is speculation, not a confirmed root cause.auto-review-fixintegration adds the Chinese translation block to the approval display; it does not alter the review decision. Its review-context guard produced noreview context trimmedentry for this new-format request.All reactions