Repository navigation
Replies: 1 comment
|
The root cause and proposed diff are completely accurate. The transition from packaged 1. Immediate Non-Destructive Workaround (Without editing JS)For anyone on rc.3 running into this before the patch release lands, you can bridge the path with an NTFS directory junction in an administrative terminal: cd /d "<install-root>\resources\app"
mklink /J runtime "..\runtime"Because 2. Upstream Fix AssessmentThe diff: - await runDesktopCli(join(dirname(runtimeArchivePath(runtimeDir) ?? runtimeDir), "runtime"));
+ await runDesktopCli(join(dirname(runtimeArchivePath(runtimeDir) ?? dirname(runtimeDir)), "runtime"));This is fully backwards-compatible:
Please submit the PR for this; it's a clean, zero-regression fix for the desktop launcher. |
Uh oh!
There was an error while loading. Please reload this page.
Environment
desktopSymptom
Every
dsh plugin --profile desktop <subcommand>invocation crashes instantly. The plugin-market GUI's install / update / uninstall actions (which spawn the same CLI) fail the same way, so on rc.3 no plugin can be installed or updated from the UI at all.Minimal reproduction
Note the extra
app\segment: the real pnpm launcher lives at<install-root>\resources\runtime\primary-runtime\dependencies\pnpm\bin\pnpm.mjs— the computed path has oneapplevel too many.Root cause
In
dsh-desktop-host/lib/cli.js(bundled with the Desktop app):runtimeArchivePath()only returns a value when the parent directory is namedapp.asar. In rc.2 (asar layout) this was correct. In rc.3 the app ships unpacked underresources\app\, soruntimeDirresolves toresources\app\dsh, the asar check no longer matches, and the fallback usesruntimeDiritself;dirname()then yieldsresources\app, and joining"runtime"produces the wrongresources\app\runtime\....One-line fix
Verified locally: after the patch,
dsh plugin --profile desktop why dsh-opsanddsh plugin --profile desktop listboth exit 0.Impact
dsh pluginsubcommands on Desktop rc.3 (Windows; other platforms unverified)dsh plugin addHappy to test a fix build or provide anything else needed.
All reactions