[Bug] grep skips gitignored children; README and glob include them

[muhammadsamir11]

Summary

@deepseek-ai/dsh-tool-fs-search documents that both search tools include hidden and ignored files (excluding VCS metadata). glob does. grep does not. A search whose root sits above a gitignored directory returns the same No matches found as a real miss, so a model cannot tell that node_modules was pruned.

This is present in published 0.2.0-rc.2 and on current master (packages/fs/tool-fs-search/src/grep.ts, src/glob.ts). tools.spec.ts locks the grep argv without --no-ignore or --hidden.

Reproduction

In a git repo whose root .gitignore contains node_modules, with a file vendor/node_modules/pkg/lib/index.js that contains the string NEEDLE:

1. grep with pattern: NEEDLE and path: vendor (ripgrep 15, the argv from buildGrepCommand: --json --regexp=NEEDLE -- vendor).
2. The same pattern with path: vendor/node_modules/pkg.
3. glob with pattern: **/index.js and path: vendor.

Equivalent rg (packaged @vscode/ripgrep 15.0.0):

rg --no-config --regexp=NEEDLE -- vendor
# exit 1. debug: ignoring vendor/node_modules (gitignore rule node_modules)

rg --no-config --no-ignore --hidden --regexp=NEEDLE -- vendor
# match: vendor/node_modules/pkg/lib/index.js

rg --no-config --regexp=NEEDLE -- vendor/node_modules/pkg
# match, no --no-ignore required

Ripgrep whitelists an explicit path even when that path is gitignored. Children that match another ignore rule are still skipped. So naming the package directory works; naming its parent does not.

Current behavior

• buildGlobCommand passes --no-ignore and --hidden, then excludes .git, .svn, .hg, .bzr, .jj, .sl. The glob tool description says it includes hidden and ignored files.
• buildGrepCommand is --json, --regexp=…, optional --glob=, optional -- <path>. runRipgrep adds --no-config for both tools. Grep does not pass --no-ignore or --hidden. The grep tool description does not say ignored directories are skipped.
• The package README summary says searches "include hidden and ignored files while excluding VCS metadata." That sentence covers both tools. The grep implementation and its argv tests do not.
• An empty grep is No matches found with total: 0. Nothing says a gitignored child was pruned.

Observed in a workspace that vendors Harness under apps/desktop/runtime/node_modules: grep of heroWorkspaceRow with path: apps/desktop/runtime returned No matches found. The same pattern with --no-ignore finds dsh-client-ui-conversation/lib/client.js. A later call whose path was apps/desktop/runtime/node_modules/@deepseek-ai/dsh-client-ui-conversation returned matches. grep of heroWorkspaceRow with path: node_modules at the repo root was a true empty (zero hits even with --no-ignore).

Expected behavior

Either grep matches the README and searches hidden and ignored files the way glob does, or the README, the grep description, and the empty result say that gitignored children are skipped. A parent-directory search should not look identical to "the symbol is not there."

Adding --no-ignore to every grep would match the README, and it would also pull node_modules, dist, and other ignored trees into workspace-wide searches that already stop at grepMaxMatches (250). Those copies can crowd out project hits. A result that names the skip would fix the false empty without that cost.

Environment

• Package: @deepseek-ai/dsh-tool-fs-search@0.2.0-rc.2 (packages/fs/tool-fs-search on master)
• Ripgrep: @vscode/ripgrep 15.0.0
• Platform: macOS, darwin arm64
• No plugin config changes this. The only search setting in our preset is sampleOverCapGlobResults: false.