Add SuperComponent tutorial #396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
* remove the `haystack_2` field from index.toml
bilgeyucel
reviewed
Apr 18, 2025
There was a problem hiding this comment.
@julian-risch I have updated the tutorial (extended the conclusion, changed some explanation etc.), I think it's good to go as is.
Let's resolve the serde issue, but it's completely fine if we remove that section from the tutorial.
|
serde issue is a bug in DocumentPreprocessor. I discussed with Sebastian and he opened a Haystack PR: deepset-ai/haystack#9277 |
|
The bug is fixed now and the tutorial runs without issues. |
bilgeyucel
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #394
@bilgeyucel There seems to be an issue with the Serialization/Deserialization that I couldn't investigate further.