Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Adapt benchmarking utils #5003

Merged
merged 7 commits into from
May 25, 2023
Merged

refactor: Adapt benchmarking utils #5003

merged 7 commits into from
May 25, 2023

Conversation

bogdankostic
Copy link
Contributor

Related Issues

Proposed Changes:

This PR adapts removes legacy code from benchmarks/utils.py and instead adds the methods prepare_environment, launch_document_store, download_from_url, and load_eval_data.

How did you test it?

Notes for the reviewer

The added utility methods will be used in the refactored benchmarking.

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added tests that demonstrate the correct behavior of the change
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

This was referenced May 23, 2023
Closed
Merged
Merged
Merged
Merged
@coveralls
Copy link
Collaborator

coveralls commented May 23, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5077814759

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 39.621%
Totals Coverage Status
Change from base Build 5077812065: 0.0%
Covered Lines: 8876
Relevant Lines: 22402
💛 - Coveralls

@bogdankostic bogdankostic marked this pull request as ready for review May 24, 2023 06:24
@bogdankostic bogdankostic requested a review from a team as a code owner May 24, 2023 06:24
@bogdankostic bogdankostic requested review from ZanSara and removed request for a team May 24, 2023 06:24
vblagoje
vblagoje reviewed May 25, 2023
View reviewed changes
test/benchmarks/utils.py
Launch a DocumentStore Docker container.
"""
java_opts = None if n_docs < 500000 else "-Xms4096m -Xmx4096m"
if document_store == "ElasticsearchDocumentStore":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want we can make these callables. In a benchmark setup part, we can register all document stores and their run callables and then here execute those callables.

@vblagoje vblagoje self-requested a review May 25, 2023 08:50
vblagoje
vblagoje approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@vblagoje vblagoje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bogdankostic bogdankostic merged commit c5f0f82 into main May 25, 2023
@bogdankostic bogdankostic deleted the adapt_benchmarking_utils branch May 25, 2023 09:19
@ZanSara ZanSara removed their request for review May 31, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vblagoje vblagoje vblagoje approved these changes

Assignees
No one assigned
Labels
topic:tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bogdankostic @coveralls @vblagoje