Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TopPSampler docstrings #7205

Merged
merged 2 commits into from
Feb 26, 2024
Merged

TopPSampler docstrings #7205

merged 2 commits into from
Feb 26, 2024

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 requested a review from a team as a code owner February 26, 2024 15:35
@anakin87 anakin87 requested review from julian-risch and shadeMe and removed request for a team and julian-risch February 26, 2024 15:35
@github-actions github-actions bot added 2.x Related to Haystack v2.0 type:documentation Improvements on the docs labels Feb 26, 2024
@anakin87 anakin87 added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Feb 26, 2024
@coveralls
Copy link
Collaborator

coveralls commented Feb 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8052063843

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 89.929%
Files with Coverage Reduction New Missed Lines %
components/samplers/top_p.py 3 93.48%
Totals Coverage Status
Change from base Build 8051047706: 0.0%
Covered Lines: 5206
Relevant Lines: 5789
💛 - Coveralls

shadeMe
shadeMe suggested changes Feb 26, 2024
View reviewed changes
haystack/components/samplers/top_p.py Outdated Show resolved Hide resolved
@anakin87 anakin87 requested a review from shadeMe February 26, 2024 16:15
@anakin87 anakin87 merged commit e0b6924 into main Feb 26, 2024
20 checks passed
@anakin87 anakin87 deleted the sampler_docstrings branch February 26, 2024 17:06
@anakin87 anakin87 mentioned this pull request Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadeMe shadeMe shadeMe approved these changes

Assignees
No one assigned
Labels
2.x Related to Haystack v2.0 ignore-for-release-notes PRs with this flag won't be included in the release notes. type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docstrings - haystack.components.samplers
3 participants
@anakin87 @coveralls @shadeMe