-
Notifications
You must be signed in to change notification settings - Fork 2
Add texts from paper #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
I think in the SimilarityAdoption notebook a cell got lost. Right under the cell with "First, let's check whether all runs have converged:" |
I was unable to run the ModularNetwork notebook because of the following error when I ran the cell with step 1: initializing the simulation `NameError Traceback (most recent call last) ~\Miniconda3\lib\site-packages\defSim\Simulation.py in initialize_simulation(self) ~\Miniconda3\lib\site-packages\defSim\agents_init\agents_init.py in initialize_attributes(network, realization, **kwargs) ~\Miniconda3\lib\site-packages\defSim\agents_init\CorrelatedContinuousInitializer.py in initialize_attributes(self, network) NameError: name 'neighbor_similarity_feature' is not defined` |
Found the problem for this one: missed a reference to neighbor_similarity_feature when changing the neighbor similarity feature to an attribute rather than a parameter of the function. Should be self.neighbor_similarity_feature. I can update this later, and this fix should be included in the defSim version we share for review. |
Nice! |
The version you get from GitHub should be the most up to date, the pip version can be a bit behind (we have to manually release a new version to PyPi). The above issue is fixed in the main GitHub branch now. The example still won't run, because apparently a parameter in one of the networkx functions was removed at some point. If you change that the example works. However, the results seem to be inconsistent from run to run despite having fixed the seed. Haven't looked into that yet, but we should definitely figure out why that is. |
which parameter do you mean? |
The following line is from the example: |
change some old links and include the texts from the paper.
What is the Leviathan example? I think this would also need an introduction?