Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lula lint integration #147

Merged
merged 18 commits into from
Jun 18, 2024

Conversation

CloudBeard
Copy link
Contributor

PR Overview

Created Task: Initial Lula Lint Integration

This PR introduces a task for integrating Lula Lint to check OSCAL files for correctness. #145

Key Features

  • Task Creation:

    • Implemented a task that identifies files containing oscal.yaml from a GitHub workflow.
    • The task is triggered based on the OSCAL file path from a GitHub workflow in a repository.
  • Linting Capabilities:

    • The task can handle both single and multiple files.
    • Files are linted one at a time.
    • Lula Lint ensures compliance with the OSCAL Schema.

Additional Inclusions

  • Test-Lint Task:

    • Added a test-lint task to verify the functionality.
  • Supporting Files:

    • Included a correct OSCAL file for linting test purposes.

By integrating Lula Lint, we aim to enhance the accuracy and compliance of OSCAL files in our workflow. This task will streamline the linting process, ensuring all files meet the required standards.

@CloudBeard CloudBeard requested review from a team as code owners June 11, 2024 08:56
@CloudBeard CloudBeard changed the title Lula lint integration feat: lula lint integration Jun 11, 2024
tasks.schema.json Outdated Show resolved Hide resolved
tasks/lula.yaml Outdated Show resolved Hide resolved
tasks/lula.yaml Outdated Show resolved Hide resolved
tasks/lula.yaml Outdated Show resolved Hide resolved
tasks/lula.yaml Outdated Show resolved Hide resolved
tasks.yaml Outdated Show resolved Hide resolved
tasks.yaml Outdated Show resolved Hide resolved
.github/actions/setup/action.yaml Show resolved Hide resolved
tasks/tests/lula-test/oscal.yaml Outdated Show resolved Hide resolved
@CloudBeard CloudBeard marked this pull request as draft June 14, 2024 07:08
@CloudBeard CloudBeard marked this pull request as ready for review June 14, 2024 11:15
renovate.json Outdated Show resolved Hide resolved
.github/actions/setup/action.yaml Outdated Show resolved Hide resolved
tasks/lint.yaml Show resolved Hide resolved
.github/workflows/lint.yaml Outdated Show resolved Hide resolved
oscal.yaml Show resolved Hide resolved
tasks/lint.yaml Outdated Show resolved Hide resolved
tasks/lint.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@zachariahmiller zachariahmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Racer159 Racer159 merged commit 7f357e0 into defenseunicorns:main Jun 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants