-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error on outlook.office.com #141
Comments
this fix guards against edge cases where the contentEditable being monitored does not have an offsetParent, which can happen if the node has position of 'fixed'. fixes #141
To be clear, I think we can release if this isn’t resolved easily and quickly. The user doesn’t experience anything and I only noticed the errors because I’m in developer mode on the extensions page.
…-Tami
@tamireiss / tamireiss.com ( http://tamireiss.com )
Sent via Superhuman iOS ( ***@***.*** )
On Tue, Jan 11 2022 at 8:00 AM, Steve Brudz < ***@***.*** > wrote:
While testing on outlook.office.com, Tami got the following error:
image (
https://user-images.githubusercontent.com/1520763/148942016-ea766062-bca3-46e0-997a-b9cc489cf905.png
)
>
>
> It seems that it happened once I opened an email not in the main pane but
> in the modal that shows up if theres an attachment that you are
> previewing. But when I did the same thing (opened another email with a
> different attachment), nothing happened.
>
>
The first attachment was an excel document.
This is the last known issue blocking full public release of v2.1.
—
Reply to this email directly, view it on GitHub (
#141 ) , or unsubscribe
(
https://github.com/notifications/unsubscribe-auth/AAMWI55FTHZ42N2VBKOGRNLUVQSVTANCNFSM5LWH33EQ
).
Triage notifications on the go with GitHub Mobile for iOS (
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
) or Android (
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
).
You are receiving this because you are subscribed to this thread. Message
ID: <defmethodinc/just-not-sorry/issues/141 @ github. com>
|
this fix guards against edge cases where the contentEditable being monitored does not have an offsetParent, which can happen if the node has position of 'fixed'. fixes #141
🎉 This issue has been resolved in version 2.1.0-beta.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
@tamireiss That's good to know. The fix was easy, so hopefully the release above resolves the issue and we can release. |
this fix guards against edge cases where the contentEditable being monitored does not have an offsetParent, which can happen if the node has position of 'fixed'. fixes #141
🎉 This issue has been resolved in version 2.1.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This issue has been resolved in version 2.3.1-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
While testing on outlook.office.com, Tami got the following error:
The first attachment was an excel document.
This is the last known issue blocking full public release of v2.1.
The text was updated successfully, but these errors were encountered: