Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on outlook.office.com #141

Closed
sbrudz opened this issue Jan 11, 2022 · 5 comments · Fixed by #142 or #143
Closed

Error on outlook.office.com #141

sbrudz opened this issue Jan 11, 2022 · 5 comments · Fixed by #142 or #143

Comments

@sbrudz
Copy link
Contributor

sbrudz commented Jan 11, 2022

While testing on outlook.office.com, Tami got the following error:
image

It seems that it happened once I opened an email not in the main pane but in the modal that shows up if theres an attachment that you are previewing. But when I did the same thing (opened another email with a different attachment), nothing happened.

The first attachment was an excel document.

This is the last known issue blocking full public release of v2.1.

sbrudz added a commit that referenced this issue Jan 11, 2022
this fix guards against edge cases where the contentEditable being monitored does not have an
offsetParent, which can happen if the node has position of 'fixed'.

fixes #141
@tamireiss
Copy link
Contributor

tamireiss commented Jan 11, 2022 via email

sbrudz added a commit that referenced this issue Jan 11, 2022
this fix guards against edge cases where the contentEditable being monitored does not have an
offsetParent, which can happen if the node has position of 'fixed'.

fixes #141
@sbrudz sbrudz linked a pull request Jan 11, 2022 that will close this issue
just-not-sorry-bot pushed a commit that referenced this issue Jan 11, 2022
# 2.1.0-beta.2 (2022-01-11)

### Bug Fixes

* add support for outlook web for business ([7c8ad03](7c8ad03))
* fix error when previewing attachment on outlook.office.com ([3c05d57](3c05d57)), closes [#141](#141)
@github-actions
Copy link

🎉 This issue has been resolved in version 2.1.0-beta.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@sbrudz
Copy link
Contributor Author

sbrudz commented Jan 11, 2022

@tamireiss That's good to know. The fix was easy, so hopefully the release above resolves the issue and we can release.

sbrudz added a commit that referenced this issue Jan 12, 2022
this fix guards against edge cases where the contentEditable being monitored does not have an
offsetParent, which can happen if the node has position of 'fixed'.

fixes #141
just-not-sorry-bot pushed a commit that referenced this issue Jan 12, 2022
## 2.1.2 (2022-01-12)

### Bug Fixes

* fix error when previewing attachment on outlook.office.com ([8a1efdf](8a1efdf)), closes [#141](#141)
@github-actions
Copy link

🎉 This issue has been resolved in version 2.1.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

just-not-sorry-bot pushed a commit that referenced this issue Aug 8, 2022
## 2.3.1-beta.1 (2022-08-08)

### Bug Fixes

* add support for outlook web for business ([7c8ad03](7c8ad03))
* fix error when previewing attachment on outlook.office.com ([3c05d57](3c05d57)), closes [#141](#141)
@github-actions
Copy link

github-actions bot commented Aug 8, 2022

🎉 This issue has been resolved in version 2.3.1-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants