Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two more expressions as warnings #144

Closed
sbrudz opened this issue Jan 25, 2022 · 3 comments
Closed

Add two more expressions as warnings #144

sbrudz opened this issue Jan 25, 2022 · 3 comments

Comments

@sbrudz
Copy link
Contributor

sbrudz commented Jan 25, 2022

Request from MSc Patricia Koops via the just-not-sorry email list:

Hi,

I hope this email find you well.

I miss two expressions in your app which women use a lot and should not use:

“If that’s okay”

and

“if that makes sense.”

Please add it.

Thanks!

BW,

LG,

Met vriendelijke groeten,

MSc Patricia Koops

Transformational Life Coach

Follow me on Instagram: https://www.instagram.com/fiercely_kind_coaching/

sbrudz added a commit that referenced this issue Mar 31, 2022
include "if that makes sense" as one of the patterns that triggers the "does that make sense"
warning

re #144
sbrudz added a commit that referenced this issue Mar 31, 2022
include "if that makes sense" as one of the patterns that triggers the "does that make sense"
warning

re #144
just-not-sorry-bot pushed a commit that referenced this issue Mar 31, 2022
# 2.3.0 (2022-03-31)

### Features

* add "if that makes sense" as a warning ([c87c9ad](c87c9ad)), closes [#144](#144)
@sbrudz
Copy link
Contributor Author

sbrudz commented Mar 31, 2022

PR #151 completes half of this request. For the other half, I need to sync up with @tamireiss about what text and source to use for "If that’s okay". The original source provided by Patricia was this tweet. There's not much context as to why someone shouldn't use this phrase, though.

@tamireiss
Copy link
Contributor

tamireiss commented Mar 31, 2022 via email

@sbrudz
Copy link
Contributor Author

sbrudz commented Jan 25, 2023

Completed by #168

@sbrudz sbrudz closed this as completed Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants