-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Website publishing improvements #165
Conversation
use jekyll data files instead
Had an issue running bundle install locally on my machine:
but was able to resolve it with this https://stackoverflow.com/questions/74196882/cannot-install-jekyll-eventmachine-on-m1-mac |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving but had one question about a file not sure is required.
What version of ruby and openssl were you using? I wonder if I should upgrade to ruby 3 since 2.7's EOL is in March. |
I had to install 2.7 with rvm to start the
However I noticed that locally this updated |
I create a new issue for the ruby upgrade: #171 |
This seems to be fine as the PLATFORM gets updated when |
Yup I'm on 13! |
PRs require the nodejs build check to be successful in order to merge. Prior to this change, if we only changed a file in the `./site` directory for a PR, then the nodejs build wouldn't trigger and the PR couldn't be merged.
This allows the CI build to pass
@jduffy3 I added a job to the justnotsorry.com GitHub Action workflow that will run |
🎉 This PR is included in version 2.5.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This PR improves the publishing process for https://justnotsorry.com with the goal of making website updates easier and clearer.
Changes include:
gh-pages
branch into thesite
subdirectorysite
subdirectory to thegh-pages
branchphrases.json