Don't test semicolon separators in urlencoded data #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python no longer accepts ";" as a separator for `urllib.parse.parse_qs` by default (https://bugs.python.org/issue42967), causing the multipart test suite to fail with recent Python versions (3.6.13, 3.7.10, 3.8.8, 3.9.2, 3.10.0a6). While we could detect the availability of the `separator` argument and pass it, since `application/x-www-form-urlencoded` data in `POST` and `PUT` requests is probably not an issue for web cache poisoning, the current HTML spec seems clear that only "&" should be considered, so follow along with Python's API change.
|
@defnull, does this look OK to you? It's blocking a couple of other PRs. |
|
I'll just go ahead and merge this. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python no longer accepts ";" as a separator for
urllib.parse.parse_qsby default (https://bugs.python.org/issue42967), causing the multipart
test suite to fail with recent Python versions (3.6.13, 3.7.10, 3.8.8,
3.9.2, 3.10.0a6).
While we could detect the availability of the
separatorargument andpass it, since
application/x-www-form-urlencodeddata inPOSTandPUTrequests is probably not an issue for web cache poisoning, thecurrent HTML spec seems clear that only "&" should be considered, so
follow along with Python's API change.