Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JavaFX (Fix issue with freezes when using AMD GPUs on Linux system) #7451

Merged
merged 1 commit into from Mar 8, 2023

Conversation

AGulev
Copy link
Contributor

@AGulev AGulev commented Mar 7, 2023

JavaFX updates to the latest at the moment 19.0.2.1 version. It will help with stability and performance, especially on Linux.

Fix #7408

PR checklist

  • Code
    • Add engine and/or editor unit tests.
    • New and changed code follows the overall code style of existing code
    • Add comments where needed
  • Documentation
    • Make sure that API documentation is updated in code comments
    • Make sure that manuals are updated (in github.com/defold/doc)
  • Prepare pull request and affected issue for automatic release notes generator
    • Pull request - Write a message that explains what this pull request does. What was the problem? How was it solved? What are the changes to APIs or the new APIs introduced? This message will be used in the generated release notes. Make sure it is well written and understandable for a user of Defold.
    • Pull request - Write a pull request title that in a sentence summarises what the pull request does. Do not include "Issue-1234 ..." in the title. This text will be used in the generated release notes.
    • Pull request - Link the pull request to the issue(s) it is closing. Use on of the approved closing keywords.
    • Affected issue - Assign the issue to a project. Do not assign the pull request to a project if there is an issue which the pull request closes.
    • Affected issue - Assign the "breaking change" label to the issue if introducing a breaking change.
    • Affected issue - Assign the "skip release notes" is the issue should not be included in the generated release notes.

@AGulev AGulev requested review from vlaaad and britzl March 7, 2023 18:14
@AGulev AGulev changed the title Update JavaFX Update JavaFX (Fix issue with freezes when using AMD GPUs on Linux system) Mar 7, 2023
Copy link
Contributor

@vlaaad vlaaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@AGulev AGulev merged commit 4d9c7c9 into editor-dev Mar 8, 2023
@AGulev AGulev deleted the DEFEDIT-javafx19 branch March 8, 2023 08:56
@AGulev AGulev linked an issue Mar 8, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

too much freezes on manjaro linux
3 participants