Update blend-modes.md with Screen definition resolve #204 #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding blend mode "Screen" definition. Please review.
Adding blend mode "Screen" definition. Please review.
|
Please link to issue #204 if all looks good. Thank you. |
small indentation fix
britzl
requested changes
Oct 15, 2021
docs/en/shared/blend-modes.md
Outdated
| @@ -8,3 +8,6 @@ Add | |||
|
|
|||
| Multiply | |||
| : Darken the background with values of the the corresponding pixels of the component: `src.rgb * dst.rgb` | |||
|
|
|||
| Screen | |||
| : Opposite of Multiply. Brighten background and values of the the corresponding pixels of the component: `src.rgb - dst.rgb * dst.rgb` | |||
There was a problem hiding this comment.
"the the"
Oh, I see we have the same on Multiply!
There was a problem hiding this comment.
Got it! removed the extra "the" from both descriptions. I will make sure to proofread a bit more in future pr's !
Removed double wording "the the" in both Multiply and Screen definitions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding blend mode "Screen" definition. Please review.