Separate macOS builder #207
Conversation
| @@ -50,7 +49,8 @@ start_service() { | |||
| fi | |||
| fi | |||
|
|
|||
| nohup java -Xmx1g -XX:MaxDirectMemorySize=512m -jar ${PATH_TO_JAR} --spring.profiles.active=${PROFILE} >> ${STDOUT_LOG} 2>> ${ERROR_LOG} < /dev/null & | |||
| echo "Running: java -Xmx1g -XX:MaxDirectMemorySize=512m -jar ${PATH_TO_JAR} --spring.profiles.active=${PROFILE} >> ${STDOUT_LOG} 2>> ${ERROR_LOG} < /dev/null &" | |||
| java -Xmx1g -XX:MaxDirectMemorySize=512m -jar ${PATH_TO_JAR} --spring.profiles.active=${PROFILE} >> ${STDOUT_LOG} 2>> ${ERROR_LOG} < /dev/null & | |||
There was a problem hiding this comment.
Got "nohup: can't detach from console: Inappropriate ioctl for device"
Recommendation seems to be to remove nohup. The server is still running after the session has ended.
| @@ -35,7 +40,7 @@ if [[ ! -e ${LOGS_DIR} ]]; then | |||
| echo "[setup] Created logs directory at ${LOGS_DIR}." | |||
| fi | |||
|
|
|||
| WGET_CMD=/usr/local/bin/wget | |||
| CURL_CMD=/usr/bin/curl | |||
There was a problem hiding this comment.
wget is not installed by default on the instance. curl is.
| * Create macOS instance in AWS Console | ||
| * 100 GB storage (default is 60 GB) | ||
| * Key pair: `defold2_ec2` | ||
| * VPC: `vpc-f5e04690` Subnet: `subnet-38e0725d` | ||
| * Public IPV4 | ||
| * Security Groups: `sg-bd9926da`, `sg-f9734c9f` | ||
| * Add instance to EC2 Target Group `prod-darwin-extender` (`arn:aws:elasticloadbalancing:eu-west-1:378120250811:targetgroup/prod-darwin-extender/4a33b7844a4ad624`) |
There was a problem hiding this comment.
Is it an issue putting this info online?
There was a problem hiding this comment.
No. I wouldn't say so. The information uniquely identifies the load balancer, a virtual private cloud and subnet. The security groups are also of no use to anyone. And access to detailed information is only available to someone with access to our AWS account.
| Follow [these setup instructions](README_SETUP_RELEASE.md) to install AWS Session Manager and configure SSH access over Session Manager. | ||
|
|
||
| ``` | ||
| ssh -i ~/.ssh/defold2_ec2.pem ec2-user@i-05303831267023ab0 |
There was a problem hiding this comment.
Same here?
Previously, we've used google drive documents for this.
There was a problem hiding this comment.
Nope, ec2-user is the default user on any mac1.metal host (it is public information easily found in the AWS documentation). And knowing the instance id is of no help to anyone at all, and it is not a security concern either.
| # From Dockerfile | ||
| export XCODE_12_VERSION=12.5 | ||
| export MACOS_10_15_VERSION=10.15 | ||
| export IOS_14_VERSION=14.5 | ||
| export LIB_TAPI_1_6_PATH=/usr/local/tapi1.6/lib | ||
| export MACOS_11_VERSION=11.3 | ||
| export XCODE_12_CLANG_VERSION=12.0.5 | ||
| export SWIFT_5_VERSION=5.0 |
There was a problem hiding this comment.
I'd like a comment in the Dockerfile referencing this file as well, since it's duplicated code and easy for it to diverge
There was a problem hiding this comment.
Good point. I've updated the PR with this addition to the Dockerfile
| enabled: false | ||
| url: https://build-darwin-stage.defold.com | ||
| enabled: true | ||
| url: https://build-darwin.defold.com |
There was a problem hiding this comment.
We really have to be extra careful now, since we cannot test things as we used to.
No description provided.