Update event emitter methods #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove `off` which does not exist on `EventEmitter` or `process`. (This was my bad, as I added this in a PR a few years ago coming from my jQuery background hehe 😏) - Add two new methods that are on `EventEmitter`.
| @@ -164,10 +164,11 @@ function noop() {} | |||
| process.on = noop; | |||
| process.addListener = noop; | |||
| process.once = noop; | |||
| process.off = noop; | |||
There was a problem hiding this comment.
this could be argued to be a breaking change
|
removing off could theoretically break stuff, otherwise 👍 |
|
are there plans to also add a |
|
@dadleyy good call |
|
@feross do you mind updating this if you're able, I can't add to this pull |
|
Ah, sorry I already deleted my fork. What is the best way to add |
|
That's OK I'll just create a new one, empty array sounds right as
inheriting is probably a bad idea as it would blow up a lot of code that
used process
…On Tue, Apr 25, 2017, 5:44 PM Feross Aboukhadijeh ***@***.***> wrote:
Ah, sorry I already deleted my fork.
What is the best way to add listeners? Should it always return an empty
array? Or should we just make process actually inherit from EventEmitter?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#77 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABE4n0ZUNweWCAD0zW0sRNluGYt_98mRks5rzmlRgaJpZM4NFPwD>
.
|
|
Sounds good. Closing this PR then. |
Merged
|
done published etc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
offwhich does not exist onEventEmitterorprocess. (This was my bad, as I added this in a PR a few years ago coming from my jQuery background hehe 😏)EventEmitter.