Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Private Gists created using the web interface turn public #45

Closed
danlei opened this issue May 19, 2013 · 1 comment · Fixed by #62
Closed

Private Gists created using the web interface turn public #45

danlei opened this issue May 19, 2013 · 1 comment · Fixed by #62

Comments

@danlei
Copy link

danlei commented May 19, 2013

After a fresh install (by hand, gist.el and dependencies are fresh checkouts, Emacs 24.3.50.1), all my already existing private gists, and new ones created using the web interface are listed as public in gist-list. When editing and saving those private Gists using gist.el, they turn public on GitHub. Private Gists created via gist.el are not affected by this.
@Wilfred
Copy link

Wilfred commented Feb 14, 2014

I can confirm I'm seeing this too.

keelerm84 added a commit to keelerm84/gist.el that referenced this issue Sep 13, 2014
@keelerm84
Private Gists Created Using Web UI Turn Public
1c83425 
The possible values from the github gist API for public is false, true
or null.  json-read-from-string decodes these as true, json-false or
json-null.

We have been treating json-false as as truth value, which leads to this
mismatch.

This commit also fixes the issue where public gists created through this
package are setting the gist public attribute to null instead of false.

Fixes defunkt#45
@keelerm84 keelerm84 mentioned this issue Sep 13, 2014
Merged
@sigma sigma closed this as completed in #62 Dec 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Private Gists Created Using Web UI Turn Public keelerm84/gist.el
2 participants
@Wilfred @danlei