Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition while attempting to stream logs from the builder pod. #65

Closed
slack opened this issue Dec 29, 2015 · 1 comment · Fixed by #133
Closed

Fix race condition while attempting to stream logs from the builder pod. #65

slack opened this issue Dec 29, 2015 · 1 comment · Fixed by #133
Assignees
Labels
Milestone

Comments

@slack
Copy link
Member

slack commented Dec 29, 2015

until [ "`kubectl --namespace=${POD_NAMESPACE} get pods -o yaml ${META_NAME} | grep "phase: " | awk {'print $2'}`" == "Running" ]; do

Is very prone to race conditions. If the builder pod either never makes it to Running or transitions through Running to Terminated we might hang forever.

@slack slack added the bug label Dec 29, 2015
@slack slack added this to the v2.0-beta1 milestone Dec 29, 2015
@arschles arschles self-assigned this Dec 29, 2015
@arschles
Copy link
Member

arschles commented Jan 5, 2016

after #72 is done, we should use the k8s API client directly and watch the event stream instead of polling kubectl

yebyen pushed a commit to yebyen/builder that referenced this issue May 6, 2020
chore(glide): upgrade k8s.io/kubernetes to 1.4.12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants